Build analysis-icu client JAR #33184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin needs to be able to be installed client side because it contains doc values formats that can be returned to the transport client. To keep this simple for developers, we publish the client JAR to Maven so that they can depend on the plugin in their POM and install the plugin there.
jasontedor
added
>enhancement
review
:Delivery/Build
|
Pinging @elastic/es-core-infra |
rjernst
approved these changes
Aug 27, 2018
There was a problem hiding this comment.
LGTM, but can you add a comment and/or an issue that we should change how this is specified for the HLRC? We should not need to pull in this implementation when all that is needed is the string "collate" to be passed in the request, since none of the logic in the format is used client side.
jasontedor
added a commit
that referenced
this pull request
Aug 27, 2018
This plugin needs to be able to be installed client side because it contains doc values formats that can be returned to the transport client. To keep this simple for developers, we publish the client JAR to Maven so that they can depend on the plugin in their POM and install the plugin there.
jasontedor
added a commit
that referenced
this pull request
Aug 27, 2018
This plugin needs to be able to be installed client side because it contains doc values formats that can be returned to the transport client. To keep this simple for developers, we publish the client JAR to Maven so that they can depend on the plugin in their POM and install the plugin there.
dnhatn
added a commit
that referenced
this pull request
Aug 28, 2018
* master: [Rollup] Better error message when trying to set non-rollup index (#32965) HLRC: Use Optional in validation logic (#33104) Remove unused User class from protocol (#33137) ingest: Introduce the dissect processor (#32884) [Docs] Add link to es-kotlin-wrapper-client (#32618) [Docs] Remove repeating words (#33087) Minor spelling and grammar fix (#32931) Remove support for deprecated params._agg/_aggs for scripted metric aggregations (#32979) Watcher: Simplify finding next date in cron schedule (#33015) Run Third party audit with forbidden APIs CLI (part3/3) (#33052) Fix plugin build test on Windows (#33078) HLRC+MINOR: Remove Unused Private Method (#33165) Remove old unused test script files (#32970) Build analysis-icu client JAR (#33184) Ensure to generate identical NoOp for the same failure (#33141) ShardSearchFailure#readFrom to set index and shardId (#33161)
dnhatn
added a commit
that referenced
this pull request
Aug 28, 2018
* 6.x: [Rollup] Better error message when trying to set non-rollup index (#32965) Remove unused User class from protocol (#33137) [DOCS] Adds link to 6.3.0 release highlights Test: fix token bwc tests due to bad backport Ensure to generate identical NoOp for the same failure (#33141) [Docs] Add link to es-kotlin-wrapper-client (#32618) [Docs] Remove repeating words (#33087) Minor spelling and grammar fix (#32931) Run Third party audit with forbidden APIs CLI (part3/3) (#33052) Fix plugin build test on Windows (#33078) Watcher: Simplify finding next date in cron schedule (#33015) Remove old unused test script files (#32970) Build analysis-icu client JAR (#33184) Switch remaining tests to new style Requests (#33109) Use internal connection manager when fetching remote node info Switch remaining x-pack tests to new style Requests (#33108) Switch remaining ml tests to new style Requests (#33107) Token API supports the client_credentials grant (#33106)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin needs to be able to be installed client side because it contains doc values formats that can be returned to the transport client. To keep this simple for developers, we publish the client JAR to Maven so that they can depend on the plugin in their POM and install the plugin there.